small optimization for nonjagged branches #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=======================================
Coverage 84.84% 84.84%
=======================================
Files 11 11
Lines 1320 1320
=======================================
Hits 1120 1120
Misses 200 200
Continue to review full report at Codecov.
|
|
we may need to special case Bool julia> a = [UInt8(1) for _ = 1:3];
julia> map(ntoh, reinterpret(Bool, a))
3-element Vector{Bool}:
1
1
1
julia> ntoh.(reinterpret(Bool, a))
3-element BitVector:
1
1
1 |
|
I thought the second one is better because BitVector is 8x smaller in memory? Or is it noticeably slower? |
|
I think it throws off our type detection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to show non-jagged code paths some love when we were optimizing jagged branches earlier. This gives a 5-10% improvement in non-jagged branch speed.